[SDK] USD balance for AccountBalance #5533
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 43fbcac The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
Your org has enabled the Graphite merge queue for merging into mainAdd the label “merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix. You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link. |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Contributor
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
kien-ngo
requested review from
MananTank,
edwardysun,
gregfromstl,
jnsdls and
joaquim-verges
as code owners
![graphite-app[bot]](https://avatars.githubusercontent.com/in/158384?s=60&v=4){kind=small}
packages/thirdweb/src/react/web/ui/prebuilt/Account/balance.tsx
Outdated
Show resolved
Hide resolved
Contributor
size-limit report 📦
|
kien-ngo
force-pushed
the
kien/account-balance-in-usd
branch
from
1bf3114 to
c2329af
Compare
Contributor
|
Don't forget a changeset but lgtm |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5533 +/- ##
==========================================
+ Coverage 48.97% 50.62% +1.65%
==========================================
Files 1089 1091 +2
Lines 56891 57100 +209
Branches 4440 4590 +150
==========================================
+ Hits 27861 28908 +1047
+ Misses 28325 27478 -847
- Partials 705 714 +9
*This pull request uses carry forward flags. Click here to find out more.
|
kien-ngo
force-pushed
the
kien/pay-convert-endpoints
branch
from
dcd6b94 to
07afcee
Compare
kien-ngo
force-pushed
the
kien/account-balance-in-usd
branch
from
c2329af to
4b66fbd
Compare
packages/thirdweb/src/react/web/ui/prebuilt/Account/balance.tsx
Outdated
Show resolved
Hide resolved
|
|
||
| const client = TEST_CLIENT; | ||
|
|
||
| describe("SendFunds screen", () => { |
Member
There was a problem hiding this comment.
thank you for the tests! 76% coverage really nice 👌
Contributor
Author
There was a problem hiding this comment.
yesser, just trying to push to 80% so we can get this PR merged!
Contributor
Author
Merge activity
|
kien-ngo
force-pushed
the
kien/account-balance-in-usd
branch
from
43aeac4 to
d54a6d0
Compare
kien-ngo
force-pushed
the
kien/account-balance-in-usd
branch
from
d54a6d0 to
a6c781c
Compare
kien-ngo
force-pushed
the
kien/account-balance-in-usd
branch
from
a6c781c to
f0111e7
Compare
CNCT-2494 <!-- start pr-codex --> --- ## PR-Codex overview This PR enhances the `AccountBalance` and `ConnectButton` components to support displaying balances in fiat currency (currently only USD). It also introduces new utility functions and improves test coverage across various components. ### Detailed summary - Added `showBalanceInFiat` prop to `AccountBalance` and `ConnectButton`. - Updated `formatFn` in `AccountBalance` to accept an object of type `AccountBalanceInfo`. - Introduced `shortenLargeNumber` and `formatNumber` utility functions. - Improved tests for `ConnectButton`, `AccountBalance`, and related components. - Enhanced rendering logic for displaying balances in both token and fiat. > ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}` <!-- end pr-codex -->
kien-ngo
force-pushed
the
kien/account-balance-in-usd
branch
from
f0111e7 to
43fbcac
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CNCT-2494
PR-Codex overview
This PR introduces significant enhancements to the
AccountBalanceandConnectButtoncomponents, allowing them to display balances in fiat (USD) and improving formatting options. It also expands utility functions and adds test coverage for these features.Detailed summary
showBalanceInFiatprop toAccountBalanceandConnectButton.formatFninAccountBalanceto acceptAccountBalanceInfo.formatNumberandshortenLargeNumber.